refactor the code patcher #931
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove the
VersionedField
in favor of an optionalversions
field on a patch.--
There are 2 ways to patch the code in aws/cloudflare:
CodePatcher
is used to patch the files before the buildContentUpdater
is used to patch the files within an ESBuild buildThey are similar but do not have feature parity.
The Cf adapter mostly uses the
ContentUpdater
but does not really use the version range for now.With the recent release of 15.4, the need to apply different patches according to the Next version is becoming more important.
What I'd like to do with this PR (and some follow up PRs) is to unify the 2 mechanisms.
Next steps: